pfultz2 added inline comments.

================
Comment at: clang-tidy/ClangTidyOptions.h:80-82
+  /// \brief Turns on experimental alpha checkers from the static analyzer.
+  llvm::Optional<bool> AllowEnablingAlphaChecks;
+
----------------
alexfh wrote:
> Since this will only be configurable via a flag, this option will be global 
> (i.e. not depend on the location of the file being analyzed). I'd suggest to 
> remove this option altogether and use something else to pass it to 
> ClangTidyASTConsumerFactory. It could be stashed into 
> ClangTidyASTConsumerFactory and passed as a parameter of runClangTidy,  or it 
> could live in ClangTidyContext.
But it needs to be passed to `getCheckNames` as well, which doesn't take a 
`ClangTidyContext`.


https://reviews.llvm.org/D46159



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to