[PATCH] D46471: [HIP] Add hip offload kind

[Artem Belevich via Phabricator via cfe-commits]

tra accepted this revision.
tra added a comment.

Small nit. LGTM otherwise.



================
Comment at: lib/Driver/ToolChains/Clang.cpp:133-135
     Work(*C.getSingleOffloadToolChain<Action::OFK_Host>());
 
+  if (JA.isHostOffloading(Action::OFK_HIP))
----------------
CUDA and HIP are mutually exclusive, so this should probably be `else if`


https://reviews.llvm.org/D46471



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits