aaron.ballman added inline comments.

================
Comment at: lib/Frontend/FrontendActions.cpp:779
+  {
+    std::string Str;
+#define FEATURE(Name, Predicate)                                               
\
----------------
lebedev.ri wrote:
> This is likely to do an allocation for each feature.
> Maybe consider `llvm::SmallString<64>`
64 bytes seemed a bit tight, so I went with 128 instead. Likely still a bit too 
small, but shouldn't be too bad.


https://reviews.llvm.org/D45835



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to