phosek added a comment. In https://reviews.llvm.org/D46910#1105992, @thakis wrote:
> This changes the default triple on Windows from x86_64-pc-win32 to > x86_64-pc-windows-msvc. This breaks at least lit's make_itanium_abi_triple() > (http://llvm-cs.pcc.me.uk/utils/lit/lit/llvm/config.py#234) > > def make_itanium_abi_triple(self, triple): > m = re.match(r'(\w+)-(\w+)-(\w+)', triple) > if not m: > self.lit_config.fatal( > "Could not turn '%s' into Itanium ABI triple" % triple) > if m.group(3).lower() != 'win32': > # All non-win32 triples use the Itanium ABI. > return triple > return m.group(1) + '-' + m.group(2) + '-mingw32' > > > which in turn breaks %itanium_abi_triple in lit tests, which then breaks some > 257 tests on Windows. > > (Also visible on http://lab.llvm.org:8011/builders/clang-x64-ninja-win7 , but > that bot has been broken for a long time.) > > So I'll revert this for now. Sorry about the breakage, I wasn't aware of that test failure and never got any email (probably because the bot has been red before). I'll try to fix make_itanium_abi_triple and test it on my Windows box tomorrow before resubmitting. In https://reviews.llvm.org/D46910#1105993, @thakis wrote: > …hm looks like https://reviews.llvm.org/rL332750 touched files in both clang > and llvm, which is probably why the diff looks super confusing on phab. I'll > revert it in two pieces, I don't know how to commit changes to llvm and clang > in one revision. The change was made through monorepo and submitted via `git llvm push` which allows changing multiple projects in one commit. Repository: rC Clang https://reviews.llvm.org/D46910 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits