echristo added a comment.

I think this will work, one inline comment. Might also be good to get a few 
different test cases, e.g. one where we're not seeing the alphabetically first 
as the minimum :)



================
Comment at: lib/CodeGen/CodeGenModule.h:1085
 
+  TargetAttr::ParsedTargetAttr filterFunctionTargetAttrs(const TargetAttr *TD);
+
----------------
Needs a block comment saying what it does :)


https://reviews.llvm.org/D46541



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to