krasimir added inline comments.
================ Comment at: unittests/Format/FormatTestObjC.cpp:815 + + // No line break before closing receiver's scope. + verifyFormat("[[obj a:42] a:42\n" ---------------- jolesiak wrote: > krasimir wrote: > > What's the receiver's scope in this comment referring to? > > Also, how would the old test cases be formatted? > For a receiver: `[obj a:42]` I meant `]` as a token closing the scope. > I'll rephrase the comment to be more precise. > > Old tests were introduced in D46879. After this change the formatting will be > the same as it was before D46879, i.e. the same as for last test touched in > this change: > ``` > [[obj aaaaaa:42 > b:42] > cc:42 > d:42]; > ``` > even if > ``` > [[obj aaaaaa:42 > b:42] > cc:42 d:42]; > ``` > satisfies the column limit. Ah, I think get it now: the new code should only apply to after object blocks and not after object receivers? Is this the intention? Repository: rC Clang https://reviews.llvm.org/D47195 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits