ebevhan added inline comments.

================
Comment at: lib/CodeGen/CGExprScalar.cpp:2178
+    llvm::Value *amt =
+        llvm::ConstantInt::get(value->getType(), 1 << fbits,
+                               /*isSigned=*/type->isSignedFixedPointType());
----------------
ebevhan wrote:
> Use an APInt with the right size here instead of relying on types in the 
> compiler.
Also, what about saturating types?


Repository:
  rC Clang

https://reviews.llvm.org/D46917



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to