compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land.
x86-Linux-only test is good. LG with the discussed changes. ================ Comment at: src/DwarfInstructions.hpp:195 } + else if (i == (int)cieInfo.returnAddressRegister) + returnAddress = registers.getRegister(i); ---------------- whitequark wrote: > compnerd wrote: > > I think that we should stick to LLVM style (coddled braces) and use C++ > > style casts. > Ack re braces. > > I was copying that cast from ten lines above. Should I change that too? This > should be a static_cast, right? Yeah, it should be a `static_cast`. And, yes, it should be fine to adjust the style there too (just do it as a separate commit). Repository: rUNW libunwind https://reviews.llvm.org/D46971 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits