sammccall added inline comments.
================ Comment at: clangd/tool/ClangdMain.cpp:141 + "come from the compilation databases."), + llvm::cl::init(false), llvm::cl::Hidden); + ---------------- ilya-biryukov wrote: > sammccall wrote: > > init(true) to avoid changing behavior? > This is intentional, it seems `false` is a better default, given that all > implementation in LLVM cache it all themselves. > We should set to true for our CDB that actually needs it. WDYT? I agree the default should be false, at least eventually. I'm not sure what you're suggesting though - we change the default value of the flag in our own copy when we link against our DB that doesn't cache? That could work. I wonder if this will break others who might have similar DBs. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48071 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
