pcc added inline comments.
================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:423
+ llvm::sys::path::native(Dwo_Dir, DwoDir);
+ llvm::sys::path::append(DwoDir, Twine(Output.getFilename()) + "_dwo");
+ CmdArgs.push_back(
----------------
I think that if I pass `-gsplit-dwarf=/path/to/foo` I would expect the dwo
directory to be named `/path/to/foo`, not `/path/to/foo/something_dwo`.
================
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:428
+
+ if (Args.hasArg(options::OPT_gsplit_dwarf)) {
+ if (!Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) {
----------------
If you make this `else if (Args.hasArg(options::OPT_gsplit_dwarf)) {` you
wouldn't need the if on line 429.
https://reviews.llvm.org/D44788
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
