smeenai added inline comments.
================
Comment at: cmake/Modules/HandleOutOfTreeLLVM.cmake:52
else()
- set(LLVM_CMAKE_PATH
- "${LLVM_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm")
+ file(TO_CMAKE_PATH ${LLVM_BINARY_DIR} LLVM_BINARY_DIR_CMAKE_STYLE)
+ set(LLVM_CMAKE_PATH
"${LLVM_BINARY_DIR_CMAKE_STYLE}/lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm")
----------------
mstorsjo wrote:
> smeenai wrote:
> > Is there ever a chance LLVM_BINARY_DIR will have backslashes, or are you
> > just being extra careful (or going for consistency)?
> I'm mostly just going for consistency and copy+paste; this path identically
> matches a part from compiler-rt/cmake/Modules/CompilerRTUtils.cmake - and
> that part actually seems to have been added intentionally to fix some case:
> https://reviews.llvm.org/rL203789
Fair enough; sounds good to me.
Repository:
rCXX libc++
https://reviews.llvm.org/D48356
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
