NoQ added inline comments.

================
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1241
       if (const llvm::APSInt *I =
-              SVB.getKnownValue(State, nonloc::SymbolVal(S)))
+              SVB.getKnownValue(State, SVB.makeSymbolVal(S)))
         return Loc::isLocType(S->getType()) ? (SVal)SVB.makeIntLocVal(*I)
----------------
NoQ wrote:
> george.karpenkov wrote:
> > So what is the difference here? That `SVB.makeSymbolVal` is not always a 
> > nonloc?
> That's right; it will be a symbolic region instead.
> 
> It won't affect the result of the calculation though (hopefully) (in the 
> current implementation).
I mean, it will *sometimes* be a symbolic region (when the symbol is of pointer 
type).


Repository:
  rC Clang

https://reviews.llvm.org/D48205



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to