GBuella added inline comments.
================ Comment at: test/CodeGen/avx-builtins.c:1423 - -__m256 test_mm256_cmp_ps_true(__m256 a, __m256 b) { - // CHECK-LABEL: @test_mm256_cmp_ps_true ---------------- spatel wrote: > GBuella wrote: > > spatel wrote: > > > Why are we deleting tests instead of replacing the CHECK lines with the > > > new output? > > These cases were only added, when the TRUE/FALSE related special cases were > > added in `CGBuiltin.cpp`. Now that the special cases are removed from > > `CGBuiltin.cpp`, it seemed consistent to also remove the related special > > cases from the tests, as these are not special anymore. > > Should we have tests with all predicates? > Yes. IIUC, we would have caught the bug before it was committed if we had > proper tests for each predicate and C intrinsic. That is true! I'll try to write a script that generates all cases, but not today. Repository: rC Clang https://reviews.llvm.org/D48715 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits