chh added a comment.

Marco, latest patch does not change __gcov_flush, which is also hidden in 
libgcov.
Android coverage test programs have depended on an earlier compiler-rt that did 
not hide __gcov_flush.
If that's the only use case broken by recent change of compiler-rt, which hide 
__gcov_flush,
I think it is okay to keep compiler-rt the same as it is now.
Adding a visible llvm_gcov_flush will allow Android coverage test program to 
use it and dump system .so profiling data,
from the main test program.
Keeping an hidden __gcov_flush has the purpose that David mentioned earlier, to 
let each .so file dump its own profiling data.


https://reviews.llvm.org/D45454



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to