sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: unittests/clangd/ClangdTests.cpp:45 namespace { +// FIXME: This is copied from CodeCompleteTests.cpp. Share the code instead. +MATCHER_P(Named, Name, "") { return arg.Name == Name; } ---------------- this is trivial enough that I wouldn't bother with the fixme. You can also use ::testing::Field(&CodeCompletion::Name, "baz") directly Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48947 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits