hfinkel added a comment. > This version detects and report integers only. If there is interest of > merging the tool I can add the functionality for floats as well.
FWIW: I think that the FP check would be interesting. > Also I have seen coding guidelines suggesting "100" is grandfathered due to > 100% calculations. 2 and 10 due to logarithms, etc. Not sure where to draw > the line there. I suspect that the check will be very noisy for powers of 2 and 10 that are used as multiplicands. You might wish to exclude those. Also, what happens for enums? Especially when initialized using expressions such as 1 << 5? Some tests might be useful in this regard. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
