a.sidorin accepted this revision. a.sidorin added a comment. Hello Zoltán,
Sorry for the delay. I think the patch is fine, just some minor nits inline. ================ Comment at: unittests/AST/ASTImporterTest.cpp:234 + assert(ToAST); + createVirtualFileIfNeeded(ToAST.get(), It->FileName, It->Code); + return &*It; ---------------- Can we move the side effect into import()? ================ Comment at: unittests/AST/ASTImporterTest.cpp:1049 + ImportType(FromVar->getType().getCanonicalType(), FromVar, Lang_C); + ASSERT_FALSE(ToType.isNull()); +} ---------------- EXPECT_FALSE? https://reviews.llvm.org/D47946 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
