efriedma added inline comments.
================ Comment at: lib/CodeGen/CGBuilder.h:260 + CharUnits::fromQuantity(Offset.getSExtValue()))); + } + ---------------- Not sure about the new helper. We already have CreateStructGEP and CreateConstArrayGEP which do approximately what you want. ================ Comment at: lib/CodeGen/CGDecl.cpp:901 isa<llvm::ConstantExpr>(Init)) { - Builder.CreateDefaultAlignedStore(Init, Loc, isVolatile); + Builder.CreateAlignedStore(Init, Loc.getPointer(), Loc.getAlignment(), + isVolatile); ---------------- `Builder.CreateStore(Init, Loc, isVolatile);` Repository: rC Clang https://reviews.llvm.org/D49209 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits