acomminos marked an inline comment as done.
acomminos added inline comments.
================
Comment at: include/clang/Sema/DeclSpec.h:2552-2553
ParsedType InitCaptureType;
+ SourceLocation LocStart;
+ SourceLocation LocEnd;
+
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > How does `LocStart` relate to the existing source location `Loc`? I think
> > this should have a more descriptive name of what location is involved.
> Now that I think about this more, I wonder if this is better expressed as
> `SourceRange CaptureRange;` given that there's always a start and end and
> they should never be equal?
Sure, makes sense to me. Many other classes with attached range data appear to
use explicit start/end locations, but in this case I think it's fine.
Repository:
rC Clang
https://reviews.llvm.org/D48845
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
