Eugene.Zelenko added a comment. Adding C++ Core Guidelines alias is definitely low-hanging fruit which could be implemented within this patch.
================ Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:14 +#include "clang/ASTMatchers/ASTMatchFinder.h" + +#include <algorithm> ---------------- Please remove empty line. ================ Comment at: clang-tidy/readability/MagicNumbersCheck.cpp:30 + IngnoredValues.reserve(IngnoredValuesInput.size()); + for (const std::string &IgnoredValue : IngnoredValuesInput) { + IngnoredValues.push_back(std::stoll(IgnoredValue)); ---------------- auto could be used here because it's range loop over container. ================ Comment at: clang-tidy/readability/MagicNumbersCheck.h:14 +#include "../ClangTidy.h" + +#include <unordered_set> ---------------- Please remove empty line and also include <vector>. ================ Comment at: test/clang-tidy/readability-magic-numbers.cpp:124 + + explicit Point(T xval, T yval) noexcept : x{xval}, y{yval} { + } ---------------- Please run Clang-format over test case. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49114 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits