rjmccall added inline comments.
================
Comment at: include/clang/AST/ASTContext.h:1953
unsigned char getFixedPointIBits(QualType Ty) const;
+ FixedPointSemantics getFixedPointSema(QualType Ty) const;
+ APFixedPoint getFixedPointMax(QualType Ty) const;
----------------
rjmccall wrote:
> Please spell out "semantics" here.
You missed this request.
================
Comment at: include/clang/Basic/FixedPoint.h:64
+
+class APFixedPoint {
+ public:
----------------
This should get a documentation comment describing the class. You should
mention that, like `APSInt`, it carries all of the semantic information about
the value's type (width, signed-ness, saturating-ness, etc.), but by design it
does not carry the original C type — among other reasons, so that it can more
easily be moved to LLVM should fixed-point types gain native IR support.
Repository:
rC Clang
https://reviews.llvm.org/D48661
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
