Re: [cfe-dev] interesting ccc issue

Wed, 06 Feb 2008 08:25:24 -0800 


6 feb 2008 kl. 08.11 skrev Sam Bishop:


On Tue, February 5, 2008 5:20 pm, Anders Carlsson wrote:

 def run(args):
-    cmd = ' '.join(args)
+    cmd = ' '.join(args).replace("\"", "\\\"");
     print >> sys.stderr, cmd
     code = os.system(cmd)
Double quotes, unfortunately, are just the tip of the iceberg. Consider 
-DCMD_STRING='"echo $(ls)"' or -DNOP='do { } while (0)', for example.



Right.
This is my fault. When I proposed the subprocess.call() -> os.system() conversion, I didn't consider the -D option and that its arguments can be 
nearly anything.

I think that we will be happiest long term if we go back to using the
subprocess module and requiring a 2.4+ version of Python. We'll probably 
end up wanting other 2.4+ features anyway.
Given that Python 2.4 was released in late 2004, more than 3 years ago, I think it's safe to require 24..
The attached patch reverts the subprocess.call() -> os.system() conversion. 
A close review, of course, is welcome.  :)


Cool. I'll have a look and commit it.

Thanks!
Anders

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
cfe-dev mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

Reply via email to