My thoughts on this topic after looking at the code and the thread ...

> -----Original Message-----
> From: David Kaufman [mailto:[EMAIL PROTECTED]

> Steve Comrie <[EMAIL PROTECTED]> wrote...
>
> > ... You're
> > adding an extra level of abstraction that doesn't immediately (to me)
> > seem necessary.
> >
> > It looks like the only dynamic aspect to your template is the
> > $switches array which could easily be inserted into the template via
> > a TMPL_LOOP. You could cut your perl code down from 29 lines to about
> > 5. And you wouldn't really be adding many more lines to the template,
> > just a couple more characters per line then what's already there.

Agreed.  Using HTML::Template to store the HTML makes more sense to me too.


>
> i have to agree with that sentiment.  i haven't seen all the code (or i
> suspect the *whole* template) but it seems to me that if this is *not* an
> evil global $q variable Lance set loose, or a really bad mod_perl
> bug (which
> both seem unlikely) then the only way the string '</div>', which does not
> appear in the perl code or the template html, could have gotten into the
> param() list arguments, is if one of CGI.pm's helpful html functions
> helpfully emitted a div tag along with the form element... in
> list context,
> somehow.

My bet would be that this is either the call to 'start_form( )' or
'end_form( )'.  At least from my quick look, all the other variables should
be simple text strings.  'start_form( )' or 'end_form( )' might be doing
some tricks that are interfering with param( ), or invoking list context
somehow from this access method.  If it's not those methods, I'm stumped.


> one thing about this i am dead-sure of: the subject-line of this
> thread was
> well chosen :-)

one thing about this i am dead-sure of: using HTML::Template for a dumping
ground of CGI.pm HTML is a way to make a lot of unnecessary work for one's
self.

Thanks,


Cory Trese
Lead Web Application Developer

O'NEIL & ASSOCIATES, INC.
495 Byers Rd.
Miamisburg, Ohio 45342-3662
Phone: (937) 865-0800 ext. 3038
Fax: (937) 865-5858
E-mail: [EMAIL PROTECTED]






---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/[EMAIL PROTECTED]/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to