On Mon, 2005-05-09 at 11:12, Michael Graham wrote:
> Anyway, I've made some minor changes to Tony's patch and made a tarball
> available here:
> 
>     
> http://www.occamstoothbrush.com/downloads/perl/CGI-Application-4.0_2-plugin-patch.tgz
> 
> Changes:
> 
>   - patched against version 4.0_2
>   - now safe for persistent environments (e.g. mod_perl):
>     - any plugin can register itself
>     - only plugins loaded by $self or superclasses of $self
>       will be initialized at runtime
>   - changed implementation to use a private hash instead of
>     the symbol table for storage of registered plugins
>   - the example script is called test-plugin.pl
> 
> 
> I would appreciate feedback on this.  Does it seem like a reasonable
> solution to the callbacks issues?

I like your solution for registering plugins. I kind of felt like I was
getting ick on myself when I wrote the code for messing with the
subclass's symbol table, but I couldn't think of a better way to handle
the persistent environment problem at the time.

One little thing I noticed with the tarball you posted, You didn't undo
the change Mark made in 4.0_1 to disable registering init stage
callbacks.

> I know there are a lot of issues to sort through and everybody is short
> on time.  If the C::A maintainers decide to go ahead with this solution,
> I will be happy to write the docs and tests and to help prepare the
> release.

I'd be happy to help out as well. :-)

-- 
Tony Fraser
[EMAIL PROTECTED]
Sybaspace Internet Solutions                        System Administrator
phone: (250) 246-5368                                fax: (250) 246-5398


---------------------------------------------------------------------
Web Archive:  http://www.mail-archive.com/[email protected]/
              http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to