Mark Stosberg writes: > George Hartzell wrote: > > I've mutated the CGI::Application::Server package so that I can run a > > little development/debug server for my CGI::Application::Dispatch > > based app. > > > > I'd like some feedback on it, is it useful to anyone else and/or > > are there things that I should do differently with/to it? > > > > Did I mention that it's based on the CGI::Application::Server package, > > and that its authors should get credit for the heavy lifting? > > > > It's available at > > > > http://shrimp.alerce.com/cgiapp/CGI::Application::Dispatch::Server.pm > > George, > > This looks good to me. I could see using it myself, and appreciate the > contribution. It would be ideal if code could be directly shared with > the existing "Server" module. Perhaps sub-class it and override new() > and handle_request and add dispatch_args(). > > I realize that just leaves "_build_request", but that routine looks > complex enough to have a bug it, or some other change made. Right now > changes there need to be made in HTTP::Request::AsCGI, > CGI::Application::Server, and this module. > > I would say that perhaps CGI::Application::Server should also be > patched, so this line is moved to it's own subroutine, so it can be > easily subclassed: > > $entry_point->new->run; > > Not only did you want to change just that line, but other people may > wish to pass args to new() there. > > Beyond this, consider allowing "dispatch_args" declared directly as part > of "new()" > > new( dispatch_args => {...} ) > > I look forward to the formal release!
[I'm not really trying to win the record for slowest development of a trivial module, this project just got stuck on the back burner...] Based on your input, I've reworked the CGI::Application::Dispatch::Server module. Version 0.03 is available at: http://shrimp.alerce.com/cgiapp/CGI::Application::Dispatch::Server-0.03.pm I played with some modifications to CGI::Application:Server that would let me use their handle_request as is but the didn't think the result was worth passing back to that modules authors for consideration. I'd appreciate any additional comments that y'all might have (Mark and others). Thanks, g. --------------------------------------------------------------------- Web Archive: http://www.mail-archive.com/[email protected]/ http://marc.theaimsgroup.com/?l=cgiapp&r=1&w=2 To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
