On Thu, Jan 19, 2012 at 08:24:14PM +0100, Ferry Huberts wrote:
> From: Ferry Huberts <[email protected]>
>
> Signed-off-by: Ferry Huberts <[email protected]>
> ---
> tests/setup.sh | 4 ++--
> tests/t0108-patch.sh | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/setup.sh b/tests/setup.sh
> index b21908d..3b52de9 100755
> --- a/tests/setup.sh
> +++ b/tests/setup.sh
> @@ -20,7 +20,7 @@ unset CDPATH
> mkrepo() {
> name=$1
> count=$2
> - dir=$PWD
> + dir="$PWD"
You can skip the quotes in assignments. Variable assignments are
expanded for tilde expansion, parameter expansion, command substitution,
arithmetic expansion and quote removal - field splitting isn't
performed. If we add redundant quotes here, we should add them to all
assignments (I'm for omitting them, though).
Apart from that, I'm fine with this patch :)
> test -d "$name" && return
> printf "Creating testrepo %s\n" $name
> mkdir -p "$name"
> @@ -41,7 +41,7 @@ mkrepo() {
> git commit -m "add a+b"
> git branch "1+2"
> fi
> - cd $dir
> + cd "$dir"
> }
>
> setup_repos()
> diff --git a/tests/t0108-patch.sh b/tests/t0108-patch.sh
> index e608104..6ee70b3 100755
> --- a/tests/t0108-patch.sh
> +++ b/tests/t0108-patch.sh
> @@ -25,7 +25,7 @@ run_test 'find `cgit` signature' '
> '
>
> run_test 'find initial commit' '
> - root=$(git --git-dir=$PWD/trash/repos/foo/.git rev-list HEAD | tail -1)
> + root=$(git --git-dir="$PWD/trash/repos/foo/.git" rev-list HEAD | tail
> -1)
> '
>
> run_test 'generate patch for initial commit' '
> --
> 1.7.7.5
>
>
> _______________________________________________
> cgit mailing list
> [email protected]
> http://hjemli.net/mailman/listinfo/cgit
_______________________________________________
cgit mailing list
[email protected]
http://hjemli.net/mailman/listinfo/cgit
