On 04-04-12 18:58, Lukas Fleischer wrote:
On Wed, Apr 04, 2012 at 06:15:02PM +0200, Ferry Huberts wrote:
From: Ferry Huberts<[email protected]>

There are 2 situations:
1- empty extension: assuming text is better than highlight
    producing no output because of a missing argument.
2- no extension at all: assuming text is better than setting
    the extension to the filename, which is what now happens.

Signed-off-by: Ferry Huberts<[email protected]>
---
  filters/syntax-highlighting.sh |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/filters/syntax-highlighting.sh b/filters/syntax-highlighting.sh
index 5fcc9c9..8b09180 100755
--- a/filters/syntax-highlighting.sh
+++ b/filters/syntax-highlighting.sh
@@ -39,6 +39,9 @@
  BASENAME="$1"
  EXTENSION="${BASENAME##*.}"

+[ "${BASENAME}" == "${EXTENSION}" ]&&  EXTENSION=txt

There is no "==" in POSIX shell/test(1). This should probably be a
single equal sign ("=").

+[ -z "${EXTENSION}" ]&&  EXTENSION=txt
+
  # map Makefile and Makefile.* to .mk
  [ "${BASENAME%%.*}" == "Makefile" ]&&  EXTENSION=mk


it appears there is, or (if there is not) the line above also doesn't work (that line has been in since 56522eb, 19-11-2009)



--
Ferry Huberts

_______________________________________________
cgit mailing list
[email protected]
http://hjemli.net/mailman/listinfo/cgit

Reply via email to