2012/10/9 Jason A. Donenfeld <[email protected]>: >> + else if (!strcmp(name, "date-order")) >> + repo->date_order = atoi(value); >> + else if (!strcmp(name, "topo-order")) >> + repo->topo_order = atoi(value); >> >> + if (date_order) { >> + static const char *date_order_arg = "--date-order"; >> + vector_push(&vec, &date_order_arg, 0); >> + } >> + >> + if (topo_order) { >> + static const char *topo_order_arg = "--topo-order"; >> + vector_push(&vec, &topo_order_arg, 0); >> + } > > > Some quick testing of git log reveals that only date-order or > topo-order can be specified, and if both are specified, it just rolls > with the last one. > > As such, consider reworking these two options into a single option, > similar to how the "section-sort" option does it.
Makes sense, I'll have a look at it. >> This makes it possible to use strict commit date ordering even when >> the commit graph flag is activated. > > Does this destroy the consistency of the commit graph at all? What are > the side effects here? We have used the strict date ordering at http://git.xcsoar.org/ for a few months now and we did not experience any issues at all. _______________________________________________ cgit mailing list [email protected] http://hjemli.net/mailman/listinfo/cgit
