* Ben Boeckel <[email protected]> [2012-10-29]: > On Mon, Oct 29, 2012 at 10:22:18 +0100, Valentin Haenel wrote: > > * Ben Boeckel <[email protected]> [2012-10-28]: > > > On Mon, Oct 22, 2012 at 08:29:16 GMT, Valentin Haenel wrote: > > > > @@ -166,6 +166,7 @@ struct cgit_query { > > > > > > > > struct cgit_config { > > > > char *agefile; > > > > + char *user_envvar; > > > > > > It should be free'd where the rest of these are free'd. I don't see that > > > here. > > > > > > > char *cache_root; > > > > char *clone_prefix; > > > > char *clone_url; > > > > @@ -263,6 +264,7 @@ struct cgit_environment { > > > > char *script_name; > > > > char *server_name; > > > > char *server_port; > > > > + char *remote_user; > > > > > > Same here. > > > > Forgive me if I am mistaken, but I don't see any of those free'd > > anywhere. > > Hrm. That's...unfortunate. But likely a different patch if it's missing > altogether.
I think the reasoning is: it's a CGI, so it gets called for every request and then exits. So maybe, there is no need to free anything, because the program is short lived? V- _______________________________________________ cgit mailing list [email protected] http://hjemli.net/mailman/listinfo/cgit
