On Sat, Mar 02, 2013 at 10:08:53AM -0500, Jason A. Donenfeld wrote: > The reason evidently is that without the static modifier, it caused a > few warnings about not being forward declared: > http://www.mail-archive.com/[email protected]/msg08125.html
I don't think that applies in this case - the functions are declared in the header file. It looks to me like those warnings triggered a round of marking anything that wasn't used elsewhere as private. > I don't think it should be that much of a hassle, therefore, to > convince Junio, if we provide a patch that also squelches such > warnings. That said, we want to tread lightly. Git doesn't provide an > API, and if we start requesting changes in the name of "api > interoperability", or what have you, the git mailing list is going to > tell us to switch to libgit2 and rework a bunch of things. And while > that might make sense somewhere somehow at some point, it's part of a > separate debate I really do not want to have right now (and if you're > thinking about replying to this thread commenting on this sentence and > mentioning something about libgit2 PLEASE DO NOT -- it's for a > separate ML thread). So let's use some tact when approaching Junio > about this. Well, I've sent a message[1] so we'll see what happens... [1] http://article.gmane.org/gmane.comp.version-control.git/217326 _______________________________________________ cgit mailing list [email protected] http://hjemli.net/mailman/listinfo/cgit
