[PATCH v2 13/22] ui-refs.c: use struct strbuf instead of fixed-size buffers

[John Keeping]

Signed-off-by: John Keeping <j...@keeping.me.uk>
---
Changes since v1:
- Reset filename buffer in the print_tag_downloads loop.
- Use fmtalloc where appropriate

 ui-refs.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/ui-refs.c b/ui-refs.c
index 5bebed1..ac9ab46 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -102,7 +102,7 @@ static void print_tag_header()
 static void print_tag_downloads(const struct cgit_repo *repo, const char *ref)
 {
        const struct cgit_snapshot_format* f;
-       char *filename;
+       struct strbuf filename = STRBUF_INIT;
        const char *basename;
        int free_ref = 0;
 
@@ -114,7 +114,7 @@ static void print_tag_downloads(const struct cgit_repo 
*repo, const char *ref)
                if ((ref[0] == 'v' || ref[0] == 'V') && isdigit(ref[1]))
                        ref++;
                if (isdigit(ref[0])) {
-                       ref = xstrdup(fmt("%s-%s", basename, ref));
+                       ref = fmtalloc("%s-%s", basename, ref);
                        free_ref = 1;
                }
        }
@@ -122,13 +122,15 @@ static void print_tag_downloads(const struct cgit_repo 
*repo, const char *ref)
        for (f = cgit_snapshot_formats; f->suffix; f++) {
                if (!(repo->snapshots & f->bit))
                        continue;
-               filename = fmt("%s%s", ref, f->suffix);
-               cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename);
+               strbuf_reset(&filename);
+               strbuf_addf(&filename, "%s%s", ref, f->suffix);
+               cgit_snapshot_link(filename.buf, NULL, NULL, NULL, NULL, 
filename.buf);
                html("&nbsp;&nbsp;");
        }
 
        if (free_ref)
                free((char *)ref);
+       strbuf_release(&filename);
 }
 static int print_tag(struct refinfo *ref)
 {
-- 
1.8.2.692.g17a9715


_______________________________________________
cgit mailing list
cgit@hjemli.net
http://hjemli.net/mailman/listinfo/cgit