"Jason A. Donenfeld" <[email protected]> on Fri, 2013/05/31 02:53:
> On Wed, May 29, 2013 at 10:20 AM, Christian Hesse <[email protected]> wrote:
> > I was wondering why cgit does not ship a favicon by default. Could not
> > find any discussions about that, so I hope I do not raise a discussion
> > that has already been decided.
> 
> Looks great! Thanks Christian. Merged into master.

Do we want this to be enabled by default?
Potential patch attached.
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
From 0c74358718e92156ebc97b00f736e655faf2a60a Mon Sep 17 00:00:00 2001
From: Christian Hesse <[email protected]>
Date: Mon, 22 Jul 2013 08:56:50 +0200
Subject: [PATCH] use favicon by default

---
 cgit.c       | 1 +
 cgitrc.5.txt | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/cgit.c b/cgit.c
index f0a9acf..950b878 100644
--- a/cgit.c
+++ b/cgit.c
@@ -363,6 +363,7 @@ static void prepare_context(struct cgit_context *ctx)
 	ctx->cfg.commit_sort = 0;
 	ctx->cfg.css = "/cgit.css";
 	ctx->cfg.logo = "/cgit.png";
+	ctx->cfg.favicon = "/favicon.ico";
 	ctx->cfg.local_time = 0;
 	ctx->cfg.enable_http_clone = 1;
 	ctx->cfg.enable_index_owner = 1;
diff --git a/cgitrc.5.txt b/cgitrc.5.txt
index b072467..28684f7 100644
--- a/cgitrc.5.txt
+++ b/cgitrc.5.txt
@@ -172,9 +172,9 @@ enable-git-config::
 	scan-path, section-from-path.
 
 favicon::
-	Url used as link to a shortcut icon for cgit. If specified, it is
-	suggested to use the value "/favicon.ico" since certain browsers will
-	ignore other values. Default value: none.
+	Url used as link to a shortcut icon for cgit. It is suggested to use
+	the value "/favicon.ico" since certain browsers will ignore other
+	values. Default value: "/favicon.iso".
 
 footer::
 	The content of the file specified with this option will be included
-- 
1.8.3.3

Attachment: signature.asc
Description: PGP signature

_______________________________________________
CGit mailing list
[email protected]
http://lists.zx2c4.com/mailman/listinfo/cgit

Reply via email to