I like this. But I could imagine a bit of backlash against it -- it's a particular web service owned by a private corporation (Automattic), and some detractors might argue that an open project like this has no interest in this kind of proprietary service integration. Are there any such detractors on this list? If so, we can fill this thread with some sort of discussion. Otherwise, pending the nitpicks below, I'll merge it.
On Wed, Jan 8, 2014 at 3:53 PM, Christian Hesse <[email protected]> wrote: > + > +char * cgit_get_gravatar(const char *email) { > + unsigned char digest[MD5_DIGEST_LENGTH]; char *cgit_get_gravatar(const char *email) { > + /* The URL includes %s, which is replaced later on. So we do not need > + * extra space for termination. */ > + gravatar = malloc(strlen(GRAVATAR_URL) + MD5_DIGEST_LENGTH * 2); This is clever, but potentially error prone. _______________________________________________ CGit mailing list [email protected] http://lists.zx2c4.com/mailman/listinfo/cgit
