Am 13.01.2014 15:21, schrieb Jason A. Donenfeld: > On Mon, Jan 13, 2014 at 12:02 PM, Stefan Tatschner <[email protected]> > wrote: >> - Using inline CSS instead of this sys.stdout.print() hack. > > Please don't do this. Inline CSS makes for much bigger files, and > there's nothing in the HTML5 spec that forbids us from putting <style> > tags there in the first place.
Ok. I will revert that change. I think the best solution would be putting the style definitions in a seperate file. But I will go with the former implementation. >> - Using trac theme for pygments (it is very clean and not intrusive like the >> default or pastie theme). > > This is probably best as a separate commit, since some folks might complain. Ok. I will do this in a seperate commit. >> - I had to fix cgit.css according to a alignment issue with the line-numbers >> table. > > This is this issue, right? > https://code.google.com/p/chromium/issues/detail?id=141945 > http://data.zx2c4.com/italics-broken.png > http://data.zx2c4.com/italics-broken.html > > Why does changing the line-height to 125% fix it exactly? No, that's not the issue. By default 'pygments' adds a <pre style="line-height: 125%"> tag so I had to change the line-height of the other column as well. To be honest in my opionion it looks also a bit better with that kind of expanded line-height. Stefan
signature.asc
Description: OpenPGP digital signature
_______________________________________________ CGit mailing list [email protected] http://lists.zx2c4.com/mailman/listinfo/cgit
