On Tue, Jan 14, 2014 at 9:39 PM, John Keeping <[email protected]> wrote: > I like the simplification, but I'm not sure the result is better. Even > without the rest we should replace the strncmp with prefixcmp though.
Agreed. > > There's actually no reason we couldn't mutate "cmd" here, which would > simplify it a lot, but I'm not sure we want to remove the const > modifiers all the way through. Then we can just do "*colon = '\0'" and > use strcmp. IMHO, it's better to keep lookup tables like these in the read-only section. Let's keep the constness. _______________________________________________ CGit mailing list [email protected] http://lists.zx2c4.com/mailman/listinfo/cgit
