On Wed, Dec 17, 2014 at 5:19 AM, Lukas Fleischer <c...@cryptocrack.de>
wrote:
> Use Git's built-in ident line splitting algorithm instead of
> reimplementing it. This does not only simplify the code but also makes
> sure that cgit is consistent with Git when it comes to author parsing.
>
Thank heavens!
> + email_len = ident.mail_end - ident.mail_begin;
> + *email = xmalloc(strlen("<") + email_len + strlen(">\0"));
> + sprintf(*email, "<%.*s>", email_len, ident.mail_begin);
> +
>
strlen(">\0") -- isn't the null superfluous? Cleanup and resubmit?
_______________________________________________
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit
