John Keeping <[email protected]> on Tue, 2015/01/13 09:43:
> On Tue, Jan 13, 2015 at 09:56:47AM +0100, [email protected] wrote:
> > From: Christian Hesse <[email protected]>
> > 
> > * sort_string_list(): rename to string_list_sort() (upstream commit
> > 3383e199)
> > * update read_tree_recursive callback to pass strbuf as base (upstream
> >   commit 6a0b0b6d)
> > 
> > Signed-off-by: Christian Hesse <[email protected]>
> > ---
> > [...]
> 
> Is there any benefit to introducing a new function here?  In other
> words, is walk_tree() used anywhere else?  If not, wouldn't it be
> simpler to update the signature of the existing function?
> 
> (The same comment applies to several other places below.)

I just adopted the changes from git upstream to make things work. This is not
intended for merge... And I will take a closer look for final patch when
git v2.3.0 arrives. ;)

Our code include three functions called 'walk_tree()' in ui-plain.c,
ui-blob.c and ui-tree.c. Can this bring any trouble?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}

Attachment: pgpyBcLIoBPYY.pgp
Description: OpenPGP digital signature

_______________________________________________
CGit mailing list
[email protected]
http://lists.zx2c4.com/mailman/listinfo/cgit

Reply via email to