On Tue, Oct 04, 2016 at 10:19:20AM +0200, Christian Hesse wrote: > "Jason A. Donenfeld" <[email protected]> on Tue, 2016/10/04 10:07: > > On Tue, Oct 4, 2016 at 9:51 AM, Christian Hesse <[email protected]> wrote: > > > + hashcpy(walk_tree_ctx->matched_oid.hash, sha1); > > > + if (sha1_object_info(oid.hash, &size) != OBJ_COMMIT) > > > + type = sha1_object_info(oid.hash, &size); > > > + type = sha1_object_info(oid.hash, &size); > > > + buf = read_sha1_file(oid.hash, &type, &size); > > > + type = sha1_object_info(oid.hash, &size); > > > + buf = read_sha1_file(oid.hash, &type, &size); > > > > Presumably upstream git doesn't have an oid family of functions for these > > yet? > > No. I think I have replaced everything possible. > > John wrote a comment about changing format_notes(), but that is an upstream > function as well.
Yeah, I wasn't paying enough attention to where that functions was. This series looks good to me, so: Reviewed-by: John Keeping <[email protected]> _______________________________________________ CGit mailing list [email protected] http://lists.zx2c4.com/mailman/listinfo/cgit
