On Tue, Jun 12, 2018 at 10:35:25AM +0200, Christian Hesse wrote: > Andy Green <[email protected]> on Tue, 2018/06/12 13:53: > > 5) I get some gcc 8.1 warnings, I made a couple of patches to get around > > them. In a couple of places, the code seemed legit really. > > I do see these on Arch as well. :) > Did not find the time to address them. > > > [inline patches] > > > > I should include these or the slightly dubious warnings are just > > regarded as an annoyance? > > Definitely to be addressed. I pushed your changes here: > > https://git.zx2c4.com/cgit/commit/?h=ch/gcc-8&id=e7ac824f > > Builds without warnings and tests are happy, but I did not yet take a > detailed look.
We'll need those posted as proper patches with a sign-off though. It will also be easier to review them that way. John _______________________________________________ CGit mailing list [email protected] https://lists.zx2c4.com/mailman/listinfo/cgit
