For browsers on low-end machines running browsers without CSS
support, the default tree view displayed "logplain" when it
should be "log plain".  Stop relying on CSS and add a space
in between elements to improve accessibility.
---
 cgit.css      |  1 -
 ui-repolist.c |  2 ++
 ui-tree.c     | 12 +++++++++---
 3 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/cgit.css b/cgit.css
index 6fcd984..d4f2418 100644
--- a/cgit.css
+++ b/cgit.css
@@ -575,7 +575,6 @@ div#cgit table.list td.reposection {
 
 div#cgit a.button {
        font-size: 80%;
-       padding: 0em 0.5em;
 }
 
 div#cgit a.primary {
diff --git a/ui-repolist.c b/ui-repolist.c
index 41424c0..6187101 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -353,8 +353,10 @@ void cgit_print_repolist(void)
                if (ctx.cfg.enable_index_links) {
                        html("<td>");
                        cgit_summary_link("summary", NULL, "button", NULL);
+                       html(" ");
                        cgit_log_link("log", NULL, "button", NULL, NULL, NULL,
                                      0, NULL, NULL, ctx.qry.showmsg, 0);
+                       html(" ");
                        cgit_tree_link("tree", NULL, "button", NULL, NULL, 
NULL);
                        html("</td>");
                }
diff --git a/ui-tree.c b/ui-tree.c
index df8ad82..436c2b3 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -245,15 +245,21 @@ static int ls_item(const struct object_id *oid, struct 
strbuf *base,
        cgit_log_link("log", NULL, "button", ctx.qry.head,
                      walk_tree_ctx->curr_rev, fullpath.buf, 0, NULL, NULL,
                      ctx.qry.showmsg, 0);
-       if (ctx.repo->max_stats)
+       if (ctx.repo->max_stats) {
+               html(" ");
                cgit_stats_link("stats", NULL, "button", ctx.qry.head,
                                fullpath.buf);
-       if (!S_ISGITLINK(mode))
+       }
+       if (!S_ISGITLINK(mode)) {
+               html(" ");
                cgit_plain_link("plain", NULL, "button", ctx.qry.head,
                                walk_tree_ctx->curr_rev, fullpath.buf);
-       if (!S_ISDIR(mode) && ctx.cfg.enable_blame)
+       }
+       if (!S_ISDIR(mode) && ctx.cfg.enable_blame) {
+               html(" ");
                cgit_blame_link("blame", NULL, "button", ctx.qry.head,
                                walk_tree_ctx->curr_rev, fullpath.buf);
+       }
        html("</td></tr>\n");
        free(name);
        strbuf_release(&fullpath);
-- 
EW
_______________________________________________
CGit mailing list
CGit@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/cgit

Reply via email to