On May 3, 2006, at 1:45 PM, Reid Ellis wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1I was going to ask a similar question. e.g. I have a bug fix for Bug 5785 <https://bugzilla.osafoundation.org/show_bug.cgi?id=5785>, and I had Byran review it. Can I check it in? Bryan approved the changes.
If it's a approved bug for Alpha2 and it's been reviewed by at least one other peer who knows that code, then yes check it in.
When you check it in add to the commit message the bug number and reviewer information, for example:
bug 1234, r=stearns
Additionally, since then, Mimi has given me two new icons and asked me to space them out a bit. Should I check those changes in? Strictly speaking, they don't fix any alpha 2 bugs..
Things like icons and documentation should also have bugs assigned because QA and the Release team needs to be aware of changes to any supporting information.
Minor changes to existing images often do not need them, but that is something I would check with the bug council on a case-by-case basis.
--- Bear Build and Release Engineer Open Source Applications Foundation (OSAF) [EMAIL PROTECTED] http://www.osafoundation.org [EMAIL PROTECTED] http://code-bear.com PGP Fingerprint = 9996 719F 973D B11B E111 D770 9331 E822 40B3 CD29
PGP.sig
Description: This is a digitally signed message part
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ Open Source Applications Foundation "chandler-dev" mailing list http://lists.osafoundation.org/mailman/listinfo/chandler-dev
