[email protected] wrote:
> Revision
>     13406 <http://viewcvs.osafoundation.org/chandler?view=rev&rev=13406>
> Author
>     vajda

>          try:
>              self.itsView.commit()
>              activity.completed()
>          except Exception, e:
>              logger.exception("Commit failed")
> +            self.setStatusMessage("Commit failed with %s" %(e))

I don't think this is right, the message can not be localized AFAIK. The
exception could be anything, and almost certainly will contain English
text. Besides, exception messages are generally meant for programmers,
not end users.

I suggest showing just "Commit failed, see log for details", and log the
actual exception.

-- 
  Heikki Toivonen


Attachment: signature.asc
Description: OpenPGP digital signature

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "chandler-dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/chandler-dev

Reply via email to