Mikeal Rogers wrote:
Unless you also remove wx from the tests this will not work for rt.py as it needs to run on the tinderboxes and they do not have wx installed.

You can import the run_recorded module and run the get_test_modules which imports all of the test modules without wx or chandler being installed.


When we were talking about this in the #QA channel on IRC I thought you were talking about a simple python file to just contain the tests to run or exclude and not about adding metadata to the tests themselves.

The way we already had it was using the test metadata, we were talking about modifying it because it wasn't compatible with rt.py, my patch fixes that and rt can use the current test collector.

Wouldn't this be simple to do as a tests.py file that is pure basic python that can be loaded by both chandler and rt and just contains an exclude list and then does a simple dir walk?

I had a variety of reasons for going this route when I originally wrote it. The primary reason is that it's a lot cleaner to keep data about the tests in the tests. You can see all the changes and history of a test by looking at the svn history for that file, rather than having all the exclusion semantics in another file which you also have to keep track of.
I don't understand this part. Since these tests are generated by a recording process any accumulated meta data is going to be lost every time a test needs to be re-recorded. I also don't expect a automatically generated file like this to need to be manually edited.

I don't know what "pure basic python" means. This is all python, all the ways we run a test can use the same code, it is more dynamic than the old way but it's written and working and, in my opinion, easier to maintain.

-Mikeal
------------------------------------------------------------------------

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "chandler-dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/chandler-dev
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Open Source Applications Foundation "chandler-dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/chandler-dev

Reply via email to