On 2 Jul, 2007, at 22:36, Heikki Toivonen wrote:
D John Anderson wrote:
I'm really glad Grant noticed this. Running tests without asserts is
almost like not running tests at all. Perhaps we need a test that
complains when we run non-performance tests with -O so we don't make
this mistake again.
We've always (apart from bugs) run release mode tests with -O and
debug
mode tests without.
Umm ... did you mean "apart from fixing bugs" :)
<https://bugzilla.osafoundation.org/show_bug.cgi?id=6973>
as proposed in:
<http://lists.osafoundation.org/pipermail/chandler-dev/2006-September/
006939.html>
Tests should not rely on assert ...
Agreed; it's not so sensible.
and AFAIK they don't. If you see any assert calls in any unit,
functional or performance test it is a bug.
The unit test framework provides assertions that work even with -O
(assert* methods on classes that derive from unittest), and func
and perf tests rely on CATS or ad hoc tests.
--Grant
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Open Source Applications Foundation "chandler-dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/chandler-dev
