Any objections on committing this to the 0.7.4 branch? While not every
trunk fix needs to go into 0.7.4, this one involves a hard crash (and
prevents us from getting feedback).
--Grant
On 18 Jan, 2008, at 13:25, [EMAIL PROTECTED] wrote:
Revision16196AuthorrobindDate2008-01-18 13:25:24 -0800 (Fri, 18 Jan
2008)Log Message
Fix for Bug 11689, make sure the feedback window is not activated
from a worker thread. r=heikki
Modified Paths
• trunk/chandler/application/feedback.py
Diff
Modified: trunk/chandler/application/feedback.py (16195 => 16196)
--- trunk/chandler/application/feedback.py 2008-01-18 06:55:14 UTC
(rev 16195)
+++ trunk/chandler/application/feedback.py 2008-01-18 21:25:24 UTC
(rev 16196)
@@ -61,8 +61,7 @@
# windows popping up at the same time
return self
- def write(self, text):
-
+ def _do_write(text):
app = wx.GetApp()
view = getattr(app, 'UIRepositoryView', None)
refreshErrors = getattr(view, 'refreshErrors', 0)
@@ -73,6 +72,12 @@
wx.PyOnDemandOutputWindow.write(self, text)
+ def write(self, text):
+ if not wx.Thread_IsMain():
+ wx.CallAfter(self._do_write, text)
+ else:
+ self._do_write(text)
+
def noContinue(self, noContinue):
if self.frame is None:
self.CreateOutputWindow('')
_______________________________________________
Commits mailing list
[EMAIL PROTECTED]
http://lists.osafoundation.org/mailman/listinfo/commits
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
Open Source Applications Foundation "chandler-dev" mailing list
http://lists.osafoundation.org/mailman/listinfo/chandler-dev
