All:
I have considered rewriting this function, so I may have some useful insights.
I will review it and post my comments tomorrow.
Tom H.
________________________________
From: Brad Chamberlain [[email protected]]
Sent: Tuesday, November 19, 2013 9:12 PM
To: Chris Wailes; [email protected]
Subject: Re: [Chapel-developers] Request for Review: Refactoring Disambiguation
By Match
I've been working in this part of the code a lot lately (relatively to the rest
of the group), and so would be a logical reviewer, and am definitely interested
in reviewing it, but am not certain that I'll have time to before the end of
Thanksgiving week (and then will have some digging out from backlog to do). If
someone else from the core team wants to review it in the meantime, I can
review it post-commit after I get back; or if Chris can wait, I can do it then.
-Brad
________________________________
From: Chris Wailes [[email protected]]
Sent: Tuesday, November 19, 2013 3:50 PM
To: [email protected]
Subject: [Chapel-developers] Request for Review: Refactoring Disambiguation By
Match
This patch is a refactoring of the disambiguation_by_match function. It cleans
up the function interface, splits the functionality into several
easier-to-understand functions, and renames variables (and rearranges some
Boolean conditionals to have the naming make sense) to make their function
clearer. In addition, information from comparisons is recorded and reused to
skip over functions that can't be the best match. Lastly, the tracing enabled
by --explain-call has been improved.
- Chris
------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing
conversations that shape the rapidly evolving mobile landscape. Sign up now.
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Chapel-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/chapel-developers
