I am looking at it. Vass On 12/12/2013 03:29 PM, Brad Chamberlain wrote: > > Hi Chapel Developers -- > > A user noticed that we don't replicate global constants across locales > as we do for integers and other scalar types (and advertise in the > spec), which seemed like, and was, a five-minute fix (TM). While here, > I noticed other scalar types that weren't being replicated (imaginaries, > complexes, bools of non-default width I think?), so added them in as > well and created a test to lock the behavior in for default-sized scalar > types. > > This has passed full single-locale testing and the multilocale/ and > examples/ gasnet directories. > > Patch attached. Proposed commit message below. > > -Brad > > ----- > > > Extend replication of global constants to other types > > This commit fixes a bug/oversight in which we failed to replicate global > constants of simple types across locales as advertised in the spec. It > adds enums, imaginaries, and complexes to the list of things to be > replicated. It also changes the test used for booleans from a simple > comparison to dtBool (which I think would only cover default-width > boolean types?) to use is_bool_type(), more symmetrically with other types. > > One case that I was curious about but did not investigate (due to lack > of time, difficulty in verifying, and perhaps good motivating examples) > was whether global const class variables are replicated (which would > correspond to replicating the reference to the object, not the object > itself). So that remains an open question for future investigation. > > Added a test to lock this behavior in. > > > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk > > > > _______________________________________________ > Chapel-developers mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/chapel-developers >
------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Chapel-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/chapel-developers
