Probably that is also my fault for not making sure. I am sorry.
I will send you a patch from r22477.
Thanks,
-
Jun Nakashima
No problem!
Hello Kenjiro --
Oh! I am sorry. The delay in getting this patch installed is entirely
my fault. I had assumed that Jun would be sending me a patch, because I
didn't see one in the mail Brad forwarded to me. So, I had not done any
review yet. The fix-massivethreads-compile-error.patch you sent with
this email looks fine to me, and again, my apologies for the delay!
greg
On 12/19/2013 08:19 PM, Kenjiro Taura wrote:
Hi Ben,
I am 99% sure that this is related to an issue we already reported
to Brad and Greg: here is the original report (sent from Jun Nakashima
to Brad several weeks ago):
Recent Chapel nightly tests reported an compile error of the
runtime system with MassiveThreads tasking layer. The cause
is the change of definition of c_sublocid_any (from constant
to non-constant value).
It can be fixed by replacing c_sublocid_any in
tasks-massivethreads.c to c_sublocid_any_val, and I made a
patch to do it. Could you review it (or introduce the right
person) to commit to the source tree?
Greg is now reviewing the patch and will hopefully be committed soon
and it should be OK.
Meanwhile, you could apply this trivial patch to your own copy.
I'm trying to compile with massive threads enabled:
Variable is set to: export CHPL_TASKS=massivethreads
***** src/tasks/massivethreads/ *****
making
gen/linux64.gnu.loc-flat.tasks-massivethreads.tmr-generic.mem-default.atomics-intrinsics.gmp-none.hwloc-none.re2.wide-struct.fs-none
subdirectory to store platform-specific files
gcc -c -std=c99 -MMD -MP -O3 -DCHPL_TASKS_MODEL_H=\"tasks-massivethreads.h\"
-DCHPL_THREADS_MODEL_H=\"threads-none.h\" -DCHPL_WIDE_POINTER_STRUCT -DCHPL_OPTIMIZE
-I/usr/share/acustat/src/chapel-code/third-party/massivethreads/install/linux64-gnu/include
-I/usr/share/acustat/src/chapel-code/third-party/massivethreads/install/linux64-gnu/include -I.
-I../../../include/localeModels/flat/none -I../../../include/localeModels/flat
-I../../../include/localeModels -I../../../include/comm/none -I../../../include/comm
-I../../../include/tasks/massivethreads -I../../../include/threads/none -I../../../include/comp-gnu
-I../../../include/linux64 -I../../../include -I../../../include/qio
-I../../../include/atomics/intrinsics -I../../../include/mem/default
-I/usr/share/acustat/src/chapel-code/third-party/utf8-decoder -I../../../include/hwloc/none -o
gen/linux64.gnu.loc-flat.tasks-massivethreads.tmr-generic.mem-default.atomics-intrinsics.gmp-none.hwloc-none.re2.wide-struct.fs-none/tasks-massivet
hreads.o tasks-massivethreads.c
tasks-massivethreads.c:54:14: error: initializer element is not constant
{ c_sublocid_any, false };
^
tasks-massivethreads.c:54:14: error: (near initialization for
âs_def_chpl_data.requestedSublocâ)
tasks-massivethreads.c:58:14: error: initializer element is not constant
{ c_sublocid_any, false };
^
tasks-massivethreads.c:58:14: error: (near initialization for
âs_main_chpl_data.requestedSublocâ)
make[6]: ***
[gen/linux64.gnu.loc-flat.tasks-massivethreads.tmr-generic.mem-default.atomics-intrinsics.gmp-none.hwloc-none.re2.wide-struct.fs-none/tasks-massivethreads.o]
Error 1
make[5]: *** [massivethreads.makedir] Error 2
make[4]: *** [tasks.makedir] Error 2
make[3]: *** [src.makedir] Error 2
make[2]: *** [all.helpme] Error 2
make[1]: *** [runtime] Error 2
make: *** [comprt] Error 2
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET,& PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Chapel-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/chapel-developers
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET,& PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Chapel-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/chapel-developers
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Chapel-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/chapel-developers
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Chapel-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/chapel-developers
Index: runtime/src/tasks/massivethreads/tasks-massivethreads.c
===================================================================
--- runtime/src/tasks/massivethreads/tasks-massivethreads.c (ãªãã¸ã§ã³ 22477)
+++ runtime/src/tasks/massivethreads/tasks-massivethreads.c (ä½æ¥ã³ãã¼)
@@ -51,11 +51,11 @@
static thread_local_data* s_tld;
static const task_private_data_t s_def_chpl_data=
- { c_sublocid_any, false };
+ { c_sublocid_any_val, false };
// task-private data of main task
static task_private_data_t s_main_chpl_data =
- { c_sublocid_any, false };
+ { c_sublocid_any_val, false };
static const uint64_t c_def_stack_size = 32 * 1024 * sizeof(size_t);
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Chapel-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/chapel-developers
