I will look at this one. THH ________________________________________ From: Brad Chamberlain [[email protected]] Sent: Thursday, February 27, 2014 1:27 PM To: Chapel Sourceforge Developers List Subject: [Chapel-developers] Request for review: scalarReplace.cpp cleanup
This should be a pretty simple review -- mostly housecleaning... While working in scalarReplace.cpp this week, I noticed that we sort through cases that make for a legal scalar replacement, but then there's a nested else if conditional that has no 'else' clause which suggests that expressions could slip through and not be scalar replaced. I added an else clause with an INT_FATAL in it to help people who add new cases but then fail to replace them. While here, I also cleaned up some logic relating to unnecessarily checking too much whether call is NULL or not. -Brad ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ Chapel-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/chapel-developers
