I'll take this one. greg
On Mon, 17 Mar 2014, Brad Chamberlain wrote: > > Hi Chapel Developers -- > > size of patch = 2 out of 7 > complexity of patch = 5 out of 7 (just because Makefiles are so spaghetti > by nature) > > The attached patch is morally Michael Ferguson's, but I'd be happy for a > review from whomever if it can come sooner. > > Just prior to the last release, I noticed the amount of redundancy in the > flags we pass to 'cc' when compiling the generated code (e.g., passing > identical -Werror or -I options multiple times). These were introduced in > r19641; by the time I discovered them, I was too scared to make Makefile > changes so close to the release, so I instead I added a TODO in r21987. > > This patch makes good on that TODO by being more precise when accumulating > macros into GEN_CFLAGS and removing third-party -I flags that are added in > multiple places. I believe it maintains the original design goals that > caused Michael to introduce this redundancy in the first place. > > I've tested this by hand in a few of the major configurations > (qthreads+gasnet, massivethreads, comm=none), but the proof will be in the > nightly testing and living with it for awhile. > > Thanks, > -Brad > ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ Chapel-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/chapel-developers
